Open
Conversation
…for generator_test
|
Here's a drop in replacement that was forked from this library that already has most (all) of the feature's you've incorporated. We'd welcome some additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This Pull Request introduces a series of improvements and updates to the UUID library, including new functionality, code refactoring, and modernization of the tests. Below are the main changes:
Implementation Changes
UUID V6 and V7 Implementation:
NewV6andNewV7methods to theGeneratorinterface and their respective implementations inrfc4122Generator.Refactoring of Existing Methods:
SetVersion,SetVariant,Must, and others.Enhancements in SQL Interoperability:
ScanandValuemethods forUUIDandNullUUID, ensuring clearer and more robust handling of data in SQL interactions.Test Updates and Modernization
Migration to Testify:
testify, improving readability and the effectiveness of assertions.gopkg.in/check.v1, adopting a more standard approach withtestingandtestify.New Tests for UUID V6 and V7:
NewV6andNewV7, ensuring their correct functionality and performance.Optimization of Existing Tests:
Bytes,String,Equal,Version, andVariantto ensure complete and accurate coverage.CI
Documentation